On 17 Nov 2020, at 17:29, Jessica Clarke <jrt...@freebsd.org> wrote:
> On 17 Nov 2020, at 17:12, Adrian Chadd <adr...@freebsd.org> wrote:
>> @@ -175,8 +176,7 @@ update_firmware(int fd, uint8_t *payload, int32_t payl
>> errx(EX_OSERR, "unable to malloc %zd bytes",
>> (size_t)max_xfer_size);
>>
>> while (resid > 0) {
>> - size = (resid >= (int32_t)max_xfer_size) ?
>> - max_xfer_size : resid;
>> + size = (resid >= max_xfer_size) ? max_xfer_size : resid;
>
> MIN from the already-included sys/param.h?
>
> (Otherwise: you have an extra space after ?)
Also why is off signed when it counts up from 0?
Jess
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
