Author: mhorne
Date: Thu Oct  8 18:29:17 2020
New Revision: 366543
URL: https://svnweb.freebsd.org/changeset/base/366543

Log:
  Fix a loop condition
  
  The correct way to identify the end of the metadata is two adjacent
  entries set to zero/MODINFO_END. I made a typo and this was checking the
  first entry twice.
  
  Reported by:  rpokala
  Sponsored by: NetApp, Inc.
  Sponsored by: Klara, Inc.

Modified:
  head/sys/kern/subr_module.c

Modified: head/sys/kern/subr_module.c
==============================================================================
--- head/sys/kern/subr_module.c Thu Oct  8 18:02:05 2020        (r366542)
+++ head/sys/kern/subr_module.c Thu Oct  8 18:29:17 2020        (r366543)
@@ -496,7 +496,7 @@ preload_dump_internal(struct sbuf *sbp)
         */
        bptr = (uint32_t *)preload_metadata;
        sbuf_putc(sbp, '\n');
-       while (bptr[0] != MODINFO_END || bptr[0] != MODINFO_END) {
+       while (bptr[0] != MODINFO_END || bptr[1] != MODINFO_END) {
                sbuf_printf(sbp, " %p:\n", bptr);
                type = *bptr++;
                len = *bptr++;
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to