Author: kevans
Date: Sun Mar 29 23:59:14 2020
New Revision: 359432
URL: https://svnweb.freebsd.org/changeset/base/359432

Log:
  gdb: compile with -fcommon explicitly
  
  As described in the comment, gdb relies on some of the linker magic that
  happens with -fcommon. I suspect the life expectancy of gdb-in-base is low
  enough that this isn't worth spending much time addressing, especially given
  the vintage. Hit it with the -fcommon hammer so that it continues to just
  work.
  
  MFC after:    3 days

Modified:
  head/gnu/usr.bin/gdb/Makefile.inc

Modified: head/gnu/usr.bin/gdb/Makefile.inc
==============================================================================
--- head/gnu/usr.bin/gdb/Makefile.inc   Sun Mar 29 23:38:55 2020        
(r359431)
+++ head/gnu/usr.bin/gdb/Makefile.inc   Sun Mar 29 23:59:14 2020        
(r359432)
@@ -47,6 +47,11 @@ CFLAGS+= -I${CNTRB_GDB}/include
 CFLAGS+= -I${CNTRB_BU}/bfd
 CFLAGS+= -I${SYSROOT:U${DESTDIR}}/${INCLUDEDIR}/edit
 
+# Some bits here currently rely on some of the linker-merging magic that 
happens
+# with -fcommon.  While this is the default right now, explicitly set -fcommon
+# so that it continues to build when the default flips.
+CFLAGS+= -fcommon
+
 GENSRCS+= nm.h tm.h
 
 .if defined(GDB_CROSS_DEBUGGER)
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to