> On Mar 28, 2020, at 7:37 PM, Enji Cooper <yaneurab...@gmail.com> wrote:
>
>>
>> On Mar 27, 2020, at 8:22 PM, Brooks Davis <bro...@freebsd.org
>> <mailto:bro...@freebsd.org>> wrote:
>>
>> On Sat, Mar 28, 2020 at 01:08:20AM +0000, Enji Cooper wrote:
>>> Author: ngie
>>> Date: Sat Mar 28 01:08:20 2020
>>> New Revision: 359385
>>> URL: https://svnweb.freebsd.org/changeset/base/359385
>>> <https://svnweb.freebsd.org/changeset/base/359385>
>>>
>>> Log:
>>> Check in the generated copies of the manpages
>>>
>>> These manpages were meant to be templated once per `configure` run.
>>>
>>> Given that we're not bound by as many constants, e.g., `--prefix` isn't
>>> generally changing for kyua in the base system, having to generate the
>>> manpages each build seems slightly less than optimal.
>>>
>>> In the event that one's build environment doesn't define `$SH`, the build
>>> will also fail until this change is introduced.
>>>
>>> Instead of jumping through hoops dealing with shells or permissions, let's
>>> just cut to the chase and check the generated copies into the sourcebase
>>> under usr.bin/kyua .
>>
>> This was the wrong fix. Committing generated manpaged was
>> 100% the wrong solution and will make extra work in the
>> future. The correct fix is almost certainly the one attached to
>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245086
>> <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245086>. If someone
>> doesn't beat me to it I will revert you wrong and broken commit along
>> with the followups and commit the correct one (this certainly won't be
>> until at least tomorrow).
>
> I’ll revert my changes.
Done in r359417.
Thank you,
-Enji
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
