That might be the problem in the CI rig, but xtoolchain on CURRENT doesn't appear to provide the incorrect "12" value, and it's still broken — nothing to do with gets(3).
$ x86_64-unknown-freebsd13.0-gcc-6.4.0 -std=c99 -dM -E - < /dev/null | grep FreeBSD #define __FreeBSD__ 13 The error I hit is the one ostensibly fixed by 353408: make[4]: /obj/usr/home/conrad/src/freebsd/amd64.amd64/sys/GENERIC/modules/usr/home/conrad/src/freebsd/sys/modules/opensolaris/.depend.opensolaris_atomic.o, 5: ignoring stale .depend for /usr/home/conrad/src/freebsd/sys/cddl/contrib/opensolaris/common/atomic/amd64/opensolaris_atomic.S x86_64-unknown-freebsd13.0-gcc: error: /usr/home/conrad/src/freebsd/sys/cddl/contrib/opensolaris/common/atomic/amd64/opensolaris_atomic.S: No such file or directory x86_64-unknown-freebsd13.0-gcc: fatal error: no input files Best, Conrad On Fri, Oct 11, 2019 at 1:04 AM Dimitry Andric <d...@freebsd.org> wrote: > > On 11 Oct 2019, at 08:24, Andriy Gapon <a...@freebsd.org> wrote: > > > > On 11/10/2019 09:07, Conrad Meyer wrote: > >> Fwiw, this doesn’t seem to fix the NO_CLEAN build for amd64-xtoolchain-gcc. > > > > Does a clean build work for that configuration? > > I looked at one of CI builds and it had this: > > In file included from /workspace/src/contrib/libc++/include/__debug:26:0, > > from /workspace/src/contrib/libc++/include/utility:206, > > from /workspace/src/contrib/libc++/include/algorithm:642, > > from /workspace/src/contrib/libc++/src/algorithm.cpp:9: > > /workspace/src/contrib/libc++/include/cstdio:156:9: error: '::gets' has not > > been > > declared > > using ::gets; > > > > I recall seeing a similar problem for riscv too. > > Yes, this is an issue with the external toolchains, which pass the wrong > version of __FreeBSD__. They should set the value to 13, not 12. > > -Dimitry > _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
