On 4/20/19 9:43 AM, Enji Cooper wrote: > >> On Apr 20, 2019, at 9:38 AM, John Baldwin <j...@freebsd.org> wrote: >> >> On 4/20/19 9:32 AM, Enji Cooper wrote: >>> >>>> On Apr 20, 2019, at 9:31 AM, Enji Cooper <yaneurab...@gmail.com> wrote: >>>> >>>> >>>>> On Apr 20, 2019, at 9:30 AM, John Baldwin <j...@freebsd.org >>>>> <mailto:j...@freebsd.org>> wrote: >>>>> >>>>> On 4/20/19 8:43 AM, Enji Cooper wrote: >>>>>> Author: ngie >>>>>> Date: Sat Apr 20 15:43:28 2019 >>>>>> New Revision: 346443 >>>>>> URL: https://svnweb.freebsd.org/changeset/base/346443 >>>>>> <https://svnweb.freebsd.org/changeset/base/346443> >>>>>> >>>>>> Log: >>>>>> tests/sys/opencrypto: fix whitespace per PEP8 >>>>>> >>>>>> Replace hard tabs with four-character indentations, per PEP8. >>>>>> >>>>>> This is being done to separate stylistic changes from the tests from >>>>>> functional >>>>>> ones, as I accidentally introduced a bug to the tests when I used >>>>>> four-space >>>>>> indentation locally. >>>>>> >>>>>> No functional change. >>>>> >>>>> Wow, this is really painful for the 4-5 open reviews I have outstanding >>>>> as it >>>>> makes a merge disaster. >>>> >>>> Sorry ;_;… >>> >>> Being more constructive: I will back out the change, then reapply it >>> later. >>> Thank you, >> >> Ok, is it easy to reapply using a script or some such? Also, in general I >> do prefer >> this indentation as 1) it works out of the box in emacs, and 2) many of the >> lines in >> cryptotest.py especially are indented pretty far over making it hard to read. > > Yeah. I basically did `%s/ /. /g` in vim :). Backed out via > r346452. > Using hard tabs in python should really be verboten, except when > dealing with docstrings, etc. It’s so easy to screw up programs/introduce > dead code by not indenting things consistently with four-space indents.
To be clear, I prefer the _new_ indentation. I kept having to go back and manually use tabify in emacs to work with the current scripts, so once my pending stuff is drained I will appreciate having it converted. -- John Baldwin _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
