> On Aug 7, 2019, at 2:04 PM, Li-Wen Hsu <lw...@freebsd.org> wrote:
>
> On Thu, Aug 8, 2019 at 4:27 AM Mark Johnston <ma...@freebsd.org
> <mailto:ma...@freebsd.org>> wrote:
>>
>> On Thu, Aug 01, 2019 at 06:19:16PM +0000, Li-Wen Hsu wrote:
>>> Author: lwhsu
>>> Date: Thu Aug 1 18:19:16 2019
>>> New Revision: 350512
>>> URL: https://svnweb.freebsd.org/changeset/base/350512
>>>
>>> Log:
>>> Only skip test cases sometimes failing in CI when they are running in CI
>>>
>>> Suggested by: jhb
>>> Sponsored by: The FreeBSD Foundation
>>
>> This seems to break running the tests manually; atf dies because the
>> "ci" variable is not defined. I have to use an invocation like this to
>> avoid that:
>>
>> $ kyua -v test_suites.FreeBSD.ci=false test ptrace_test
>>
>> I suspect that share/mk/suite.test.mk needs to be augmented somehow to
>> set this variable to "false" by default, so that the CI infrastructure
>> can override that.
>
> Thanks for catching this! I feel that the better approach is using
> function that gets this variable with default value, for keeping
> things simple.
This is the right API to use:
atf_tc_get_config_var_as_bool_wd(tc, variable_name, default_value);
Just set the default to `false`.
HTH,
-Enji
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
