Author: emaste
Date: Wed Jul 24 16:51:14 2019
New Revision: 350294
URL: https://svnweb.freebsd.org/changeset/base/350294

Log:
  pf: zero output buffer in pfioctl
  
  Avoid potential structure padding leak.
  
  Reported by:  Vlad Tsyrklevich <v...@tsyrklevich.net>
  Reviewed by:  kp
  MFC after:    3 days
  Security:     Potential kernel memory disclosure
  Sponsored by: The FreeBSD Foundation

Modified:
  head/sys/netpfil/pf/pf_ioctl.c

Modified: head/sys/netpfil/pf/pf_ioctl.c
==============================================================================
--- head/sys/netpfil/pf/pf_ioctl.c      Wed Jul 24 16:10:20 2019        
(r350293)
+++ head/sys/netpfil/pf/pf_ioctl.c      Wed Jul 24 16:51:14 2019        
(r350294)
@@ -2169,7 +2169,7 @@ relock_DIOCKILLSTATES:
                        break;
                }
 
-               p = pstore = malloc(ps->ps_len, M_TEMP, M_WAITOK);
+               p = pstore = malloc(ps->ps_len, M_TEMP, M_WAITOK | M_ZERO);
                nr = 0;
 
                for (i = 0; i <= pf_hashmask; i++) {
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to