On Tue, Jul 16, 2019 at 01:41:06PM -0700, John Baldwin wrote: > On 7/16/19 12:44 PM, Shawn Webb wrote: > > On Tue, Jul 16, 2019 at 04:03:08PM +0000, Brooks Davis wrote: > >> Author: brooks > >> Date: Tue Jul 16 16:03:08 2019 > >> New Revision: 350049 > >> URL: https://svnweb.freebsd.org/changeset/base/350049 > >> > >> Log: > >> Fix two mismatches between function declaration and definition. > >> > >> In both cases, function pointer arguments were inconsistently declared > >> and the result worked because of C's odd rules around function pointer > >> (de)references. With a stricter compiler these fail to compile. > > > > And, with CFI applied to the kernel, would cause a panic. :) > > > > Good catch and thanks for the great work! > > How would an incorrect function prototype in userland cause a kernel panic?
Another good catch! I misread the intent of the patch. Sorry for the line noise. -- Shawn Webb Cofounder / Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 Tor+XMPP+OTR: latt...@is.a.hacker.sx GPG Key ID: 0xFF2E67A277F8E1FA GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2
signature.asc
Description: PGP signature
