Author: arybchik
Date: Tue Dec 25 06:57:41 2018
New Revision: 342421
URL: https://svnweb.freebsd.org/changeset/base/342421

Log:
  MFC r340826
  
  sfxge(4): fix ignoring function return value
  
  fix PreFAST issue, add missing annotation that function return value
  should not be ignored. Fix alignment.
  
  Submitted by:   Andy Moreton <amoreton at solarflare.com>
  Sponsored by:   Solarflare Communications, Inc.
  Differential Revision:  https://reviews.freebsd.org/D18096

Modified:
  stable/11/sys/dev/sfxge/common/efx.h
  stable/11/sys/dev/sfxge/common/efx_phy.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/dev/sfxge/common/efx.h
==============================================================================
--- stable/11/sys/dev/sfxge/common/efx.h        Tue Dec 25 06:56:48 2018        
(r342420)
+++ stable/11/sys/dev/sfxge/common/efx.h        Tue Dec 25 06:57:41 2018        
(r342421)
@@ -911,13 +911,13 @@ efx_phy_media_type_get(
        __in            efx_nic_t *enp,
        __out           efx_phy_media_type_t *typep);
 
-extern                                 efx_rc_t
+extern __checkReturn           efx_rc_t
 efx_phy_module_get_info(
-       __in                            efx_nic_t *enp,
-       __in                            uint8_t dev_addr,
-       __in                            uint8_t offset,
-       __in                            uint8_t len,
-       __out_bcount(len)               uint8_t *data);
+       __in                    efx_nic_t *enp,
+       __in                    uint8_t dev_addr,
+       __in                    uint8_t offset,
+       __in                    uint8_t len,
+       __out_bcount(len)       uint8_t *data);
 
 #if EFSYS_OPT_PHY_STATS
 

Modified: stable/11/sys/dev/sfxge/common/efx_phy.c
==============================================================================
--- stable/11/sys/dev/sfxge/common/efx_phy.c    Tue Dec 25 06:56:48 2018        
(r342420)
+++ stable/11/sys/dev/sfxge/common/efx_phy.c    Tue Dec 25 06:57:41 2018        
(r342421)
@@ -299,7 +299,7 @@ efx_phy_media_type_get(
                *typep = epp->ep_fixed_port_type;
 }
 
-       __checkReturn   efx_rc_t
+       __checkReturn           efx_rc_t
 efx_phy_module_get_info(
        __in                    efx_nic_t *enp,
        __in                    uint8_t dev_addr,
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to