On Thu, Nov 08, 2018 at 05:24:49PM +0100, Hans Petter Selasky wrote: > On 11/8/18 5:14 PM, Mark Johnston wrote: > > On Thu, Nov 08, 2018 at 12:43:14PM +0000, Hans Petter Selasky wrote: > >> Author: hselasky > >> Date: Thu Nov 8 12:43:13 2018 > >> New Revision: 340246 > >> URL: https://svnweb.freebsd.org/changeset/base/340246 > >> > >> Log: > >> Add /var/log/opensm.log to list of rotating log files. > >> > >> MFC after: 3 days > >> Sponsored by: Mellanox Technologies > >> > >> Modified: > >> head/usr.sbin/newsyslog/newsyslog.conf > > > > There is already an usr.sbin/newsyslog/newsyslog.d/opensm.conf. > > > Thank you. Do you have any objections adding a size limit for > opensm.conf, and also to use bzip2?
Nope. I don't interact with opensm anymore though. FWIW, opensm's logging can be quite verbose and I very often found myself wanting to go back further than the log retention limit (which was fairly small due to space constraints on OneFS). I think switching to bzip2 is a good idea, and the size limit you added looks reasonable. > > Index: usr.sbin/newsyslog/newsyslog.conf.d/opensm.conf > > =================================================================== > > --- usr.sbin/newsyslog/newsyslog.conf.d/opensm.conf (revision 339922) > > +++ usr.sbin/newsyslog/newsyslog.conf.d/opensm.conf (working copy) > > @@ -1,3 +1,3 @@ > > # $FreeBSD$ > > > > -/var/log/opensm.log 600 7 * * Z > > /var/run/opensm.pid 30 > > +/var/log/opensm.log 600 7 1000 * J > > /var/run/opensm.pid 30 > > --HPS > > >> > >> Modified: head/usr.sbin/newsyslog/newsyslog.conf > >> ============================================================================== > >> --- head/usr.sbin/newsyslog/newsyslog.conf Thu Nov 8 09:45:13 2018 > >> (r340245) > >> +++ head/usr.sbin/newsyslog/newsyslog.conf Thu Nov 8 12:43:13 2018 > >> (r340246) > >> @@ -26,6 +26,7 @@ > >> /var/log/maillog 640 7 * @T00 JC > >> /var/log/messages 644 5 1000 @0101T JC > >> /var/log/monthly.log 640 12 * $M1D0 JN > >> +/var/log/opensm.log 644 3 1000 * J > >> /var/log/devd.log 644 3 1000 * JC > >> /var/log/security 600 10 1000 * JC > >> /var/log/utx.log 644 3 * @01T05 B > >> > > > > > _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
