On Thu, 14 Jun 2018, Hans Petter Selasky wrote:
On 06/14/18 02:03, Matthew Macy wrote:
On Wed, Jun 13, 2018 at 4:47 PM, Ryan Libby <rli...@freebsd.org> wrote:
On Wed, Jun 13, 2018 at 4:30 PM, Matt Macy <mm...@freebsd.org> wrote:
Author: mmacy
Date: Wed Jun 13 23:30:54 2018
New Revision: 335094
URL: https://svnweb.freebsd.org/changeset/base/335094
Log:
fix OFED build after r335053
* ...
Please revert this patch and fix MKDEV() in:
compat/linuxkpi/common/include/linux/kdev_t.h
Instead.
The value returned by MKDEV() must be passable through MAJOR() and MINOR() to
restore the two arguments. Please make sure this is the case. Else the code
gets broken.
Are these macros for conversion of host (FreeBSD) dev_t's or target (Linux)
ones? If for the host, then I don't see any reason not to use the host APIs.
If for the target, then they shouldn't be used with the host dev_t. If for
a mixture, then the translations are very confusing, especially when they
are the identity, and many more macros are needed to reduce the confusion.
Bruce
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
