On Fri, May 11, 2018 at 5:31 PM, Jonathan T. Looney <[email protected]> wrote:
> On Fri, May 11, 2018 at 4:40 PM, Stephen Hurd <[email protected]> wrote: > > > > Author: shurd > > Date: Fri May 11 20:40:26 2018 > > New Revision: 333503 > > URL: https://svnweb.freebsd.org/changeset/base/333503 > > > > Log: > > MFC r333329, r333366, r333373 > > > > r333329: Fix off-by-one error requesting tx interrupt > > r333366: Cleanup queues when iflib_device_register fails > > r333373: Log iflib_tx_structures_setup failure in function > > > > Is this an acceptable style for MFC logs? > > I'm asking because I actually prefer this to reading (or compiling) the > concatenated log messages from several changes. However, I never knew it > was acceptable to summarize like this. If it is, I'd like to know so I can > adopt it for run-of-the-mill MFCs. > Unless there's a compelling reason to not do it, it is totally fine. I used to do mega-nanobsd MFCs exactly like this (though I may have include author of original commit sometimes). In general, anything is an acceptable style for MFC. The project hasn't set a style, and the variation between committers is large. Warner _______________________________________________ [email protected] mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "[email protected]"
