On Thu, May 3, 2018 at 11:01 AM, Sean Bruno <sbr...@freebsd.org> wrote:
>
> @@ -242,8 +241,8 @@ tf_cwnd(int ticks_since_cong, int rtt_ticks, unsigned
> {
>
> /* Equation 4 of I-D. */
> - return (((wmax * CUBIC_BETA) + (((THREE_X_PT2 * ticks_since_cong *
> - smss) << CUBIC_SHIFT) / TWO_SUB_PT2 / rtt_ticks)) >>
CUBIC_SHIFT);
> + return (((wmax * CUBIC_BETA) + (((THREE_X_PT3 * ticks_since_cong *
> + smss) << CUBIC_SHIFT) / TWO_SUB_PT3 / rtt_ticks)) >>
CUBIC_SHIFT);
> }
>
> #endif /* _NETINET_CC_CUBIC_H_ */
>
Did you analyze this to ensure that the intermediate steps in this
calculation would never overflow?
Jonathan
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
