In message <20180302223138.ga83...@spindle.one-eyed-alien.net>, Brooks
Davis wr
ites:
>
> --yrj/dFKFPuw6o+aM
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
> Content-Transfer-Encoding: quoted-printable
>
> On Fri, Mar 02, 2018 at 10:10:49PM +0000, Brooks Davis wrote:
> > Author: brooks
> > Date: Fri Mar 2 22:10:48 2018
> > New Revision: 330297
> > URL: https://svnweb.freebsd.org/changeset/base/330297
> >=20
> > Log:
> > Rename kernel-only members of semid_ds and msgid_ds.
> > =20
> > This deliberately breaks the API in preperation for future syscall
> > revisions which will remove these nonstandard members.
> > =20
> > In an exp-run a single port (devel/qemu-user-static) was found to
> > use them which it did becuase it emulates system calls. This has
> > been fixed in the ports tree.
> > =20
> > PR: 224443 (exp-run)
> > Reviewed by: kib, jhb (previous version)
> > Exp-run by: antoine
> > Sponsored by: DARPA, AFRP
> > Differential Revision: https://reviews.freebsd.org/D14490
>
> FYI, a __FreeBSD_version bump is coming along with a third commit.
Hi Brooks,
This causes ipcrm build to fail:
/opt/src/svn-current/usr.bin/ipcrm/ipcrm.c:156:14: error: variable has
incomplete type 'union semun'
union semun arg;
^
/opt/src/svn-current/usr.bin/ipcrm/ipcrm.c:156:8: note: forward
declaration of 'union semun'
union semun arg;
^
Index: usr.bin/ipcrm/ipcrm.c
===================================================================
--- usr.bin/ipcrm/ipcrm.c (revision 330299)
+++ usr.bin/ipcrm/ipcrm.c (working copy)
@@ -39,6 +39,7 @@
#define _WANT_SYSVMSG_INTERNALS
#include <sys/msg.h>
#define _WANT_SYSVSEM_INTERNALS
+#define _WANT_SEMUN
#include <sys/sem.h>
#define _WANT_SYSVSHM_INTERNALS
#include <sys/shm.h>
And:
/opt/src/svn-current/contrib/netbsd-tests/kernel/t_sysv.c:444:14:
error: variable has incomplete type 'union semun'
union semun sun;
^
/opt/src/svn-current/contrib/netbsd-tests/kernel/t_sysv.c:444:8: note:
forward declaration of 'union semun'
union semun sun;
^
Index: /opt/src/svn-current/contrib/netbsd-tests/kernel/t_sysv.c
===================================================================
--- /opt/src/svn-current/contrib/netbsd-tests/kernel/t_sysv.c (revision
330299)
+++ /opt/src/svn-current/contrib/netbsd-tests/kernel/t_sysv.c (working
copy)
@@ -49,6 +49,7 @@
#include <sys/ipc.h>
#include <sys/msg.h>
#include <sys/param.h>
+#define _WANT_SEMUN
#include <sys/sem.h>
#include <sys/shm.h>
#include <sys/wait.h>
I'm not sure if there are more.
--
Cheers,
Cy Schubert <cy.schub...@cschubert.com>
FreeBSD UNIX: <c...@freebsd.org> Web: http://www.FreeBSD.org
The need of the many outweighs the greed of the few.
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
