On Fri, Sep 01, 2017 at 11:23:56AM -0500, Josh Paetzel wrote:
> Yeah, the commit message is horrible.  I apologize.

I'm afraid this is not enough, esp. considering that this issue (utterly
bad commit messages) was recently brought up on developers@ once again.

Please revert and recommit with proper, elaborate, useful commit log.

> The phabricator is a little better but you have to read and parse the
> whole thing.
> 
> Then end result of this change is you can kldload ipsec AND tcpmd5,
> however ipsec support won't be in GENERIC.

Perhaps it should also explain why IPSEC_SUPPORT option is needed, as
well (e.g. if it does not cost anything, why not just optimize it away;
if it does imply something more, it should be explained and reflected
properly in the log).

./danfe
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to