Author: hselasky
Date: Tue Aug 8 11:36:57 2017
New Revision: 322250
URL: https://svnweb.freebsd.org/changeset/base/322250
Log:
Count drop events due to lack of PCI bandwidth as queue drops and not as
input errors in the mlx5en(4) driver. This improves the sysadmin view of
physical port errors.
Submitted by: gallatin@
MFC after: 1 week
Sponsored by: Mellanox Technologies
Modified:
head/sys/dev/mlx5/mlx5_en/mlx5_en_main.c
Modified: head/sys/dev/mlx5/mlx5_en/mlx5_en_main.c
==============================================================================
--- head/sys/dev/mlx5/mlx5_en/mlx5_en_main.c Tue Aug 8 11:35:27 2017
(r322249)
+++ head/sys/dev/mlx5/mlx5_en/mlx5_en_main.c Tue Aug 8 11:36:57 2017
(r322250)
@@ -552,7 +552,6 @@ mlx5e_update_stats_work(struct work_struct *work)
priv->stats.pport.alignment_err +
priv->stats.pport.check_seq_err +
priv->stats.pport.crc_align_errors +
- priv->stats.pport.drop_events +
priv->stats.pport.in_range_len_errors +
priv->stats.pport.jabbers +
priv->stats.pport.out_of_range_len +
@@ -561,7 +560,8 @@ mlx5e_update_stats_work(struct work_struct *work)
priv->stats.pport.too_long_errors +
priv->stats.pport.undersize_pkts +
priv->stats.pport.unsupported_op_rx;
- ifp->if_iqdrops = s->rx_out_of_buffer;
+ ifp->if_iqdrops = s->rx_out_of_buffer +
+ priv->stats.pport.drop_events;
ifp->if_opackets = s->tx_packets;
ifp->if_oerrors = s->tx_error_packets;
ifp->if_snd.ifq_drops = s->tx_queue_dropped;
@@ -2467,7 +2467,6 @@ mlx5e_get_counter(struct ifnet *ifp, ift_counter cnt)
priv->stats.pport.alignment_err +
priv->stats.pport.check_seq_err +
priv->stats.pport.crc_align_errors +
- priv->stats.pport.drop_events +
priv->stats.pport.in_range_len_errors +
priv->stats.pport.jabbers +
priv->stats.pport.out_of_range_len +
@@ -2478,7 +2477,8 @@ mlx5e_get_counter(struct ifnet *ifp, ift_counter cnt)
priv->stats.pport.unsupported_op_rx;
break;
case IFCOUNTER_IQDROPS:
- retval = priv->stats.vport.rx_out_of_buffer;
+ retval = priv->stats.vport.rx_out_of_buffer +
+ priv->stats.pport.drop_events;
break;
case IFCOUNTER_OPACKETS:
retval = priv->stats.vport.tx_packets;
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
