Author: avg
Date: Tue Aug  8 10:55:42 2017
New Revision: 322231
URL: https://svnweb.freebsd.org/changeset/base/322231

Log:
  8430 dir_is_empty_readdir() doesn't properly handle error from fdopendir()
  
  illumos/illumos-gate@ba6e7e6505150388de6dc6a88741164118a421bf
  
https://github.com/illumos/illumos-gate/commit/ba6e7e6505150388de6dc6a88741164118a421bf
  
  https://www.illumos.org/issues/8430
    we should close dirfd if fdopendir() fails.
  
  Reviewed by: Serapheim Dimitropoulos <seraph...@delphix.com>
  Reviewed by: Matthew Ahrens <mahr...@delphix.com>
  Reviewed by: Dan Kimmel <dan.kim...@delphix.com>
  Reviewed by: Yuri Pankov <yuri.pan...@nexenta.com>
  Reviewed by: Igor Kozhukhov <i...@dilos.org>
  Approved by: Robert Mustacchi <r...@joyent.com>
  Author: Sowrabha Gopal <sowrabha.go...@delphix.com>

Modified:
  vendor/illumos/dist/lib/libzfs/common/libzfs_mount.c

Modified: vendor/illumos/dist/lib/libzfs/common/libzfs_mount.c
==============================================================================
--- vendor/illumos/dist/lib/libzfs/common/libzfs_mount.c        Tue Aug  8 
10:52:01 2017        (r322230)
+++ vendor/illumos/dist/lib/libzfs/common/libzfs_mount.c        Tue Aug  8 
10:55:42 2017        (r322231)
@@ -209,6 +209,7 @@ dir_is_empty_readdir(const char *dirname)
        }
 
        if ((dirp = fdopendir(dirfd)) == NULL) {
+               (void) close(dirfd);
                return (B_TRUE);
        }
 
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to