On 08/02/17 12:14, Konstantin Belousov wrote:
+#define        major(x)        ((int)((dev_t)(x) >> 32)) /* major number */
+#define        minor(x)        ((int)((x) & 0xffffffff))   /* minor number */
+#define        makedev(x, y)   (((dev_t)(x) << 32) | (y))        /* create 
dev_t */

One more comment on this issue:

I think makedev(x, y) should be declared like this, to avoid issues when "y" is negative:

#define makedev(x, y) (((dev_t)(x) << 32) | (unsigned int)(y)) /* create dev_t */

???

--HPS
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to