Author: jh
Date: Mon Oct 26 14:57:33 2009
New Revision: 198491
URL: http://svn.freebsd.org/changeset/base/198491

Log:
  Fix parsing of mount options specified with -o in case an option with
  value is preceded by an option without value (for example -o
  option1,option2=value). Options must be separated before searching for
  '='. Also compare pnextopt explicitly against NULL.
  
  PR:           bin/134069
  Approved by:  trasz (mentor)

Modified:
  head/sbin/mount_nfs/mount_nfs.c

Modified: head/sbin/mount_nfs/mount_nfs.c
==============================================================================
--- head/sbin/mount_nfs/mount_nfs.c     Mon Oct 26 13:03:52 2009        
(r198490)
+++ head/sbin/mount_nfs/mount_nfs.c     Mon Oct 26 14:57:33 2009        
(r198491)
@@ -232,16 +232,16 @@ main(int argc, char *argv[])
                                char *pnextopt = NULL;
                                char *val = "";
                                pass_flag_to_nmount = 1;
-                               pval = strchr(opt, '=');
                                pnextopt = strchr(opt, ',');
+                               if (pnextopt != NULL) {
+                                       *pnextopt = '\0';
+                                       pnextopt++;
+                               }
+                               pval = strchr(opt, '=');
                                if (pval != NULL) {
                                        *pval = '\0';
                                        val = pval + 1;
                                }
-                               if (pnextopt) {
-                                       *pnextopt = '\0';
-                                       pnextopt++;
-                               }
                                if (strcmp(opt, "bg") == 0) {
                                        opflags |= BGRND;
                                        pass_flag_to_nmount=0;
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to