Author: glebius
Date: Fri Mar 24 16:01:19 2017
New Revision: 315910
URL: https://svnweb.freebsd.org/changeset/base/315910
Log:
Make sendfile(2) more robust against file change. This fixes a possible
crash when the file shrinks. This also fixes sendfile(2) not sending more
data in a case when the file grows, and the request is open-ended or
specifies a size that is greater than old file size.
PR: 217789
Reviewed by: gallatin
MFC after: 10 days
Modified:
head/sys/kern/kern_sendfile.c
Modified: head/sys/kern/kern_sendfile.c
==============================================================================
--- head/sys/kern/kern_sendfile.c Fri Mar 24 14:45:58 2017
(r315909)
+++ head/sys/kern/kern_sendfile.c Fri Mar 24 16:01:19 2017
(r315910)
@@ -689,11 +689,10 @@ retry_space:
goto done;
}
if (va.va_size != obj_size) {
- if (nbytes == 0)
- rem += va.va_size - obj_size;
- else if (offset + nbytes > va.va_size)
- rem -= (offset + nbytes - va.va_size);
obj_size = va.va_size;
+ rem = nbytes ?
+ omin(nbytes + offset, obj_size) : obj_size;
+ rem -= off;
}
}
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
