> On Mar 6, 2017, at 19:10, Ngie Cooper (yaneurabeya) <yaneurab...@gmail.com> > wrote: > >> >> On Mar 6, 2017, at 19:00, Rodney W. Grimes <free...@pdx.rh.cn85.dnsmgr.net> >> wrote: >> >> [ Charset UTF-8 unsupported, converting... ] >>> Author: ngie >>> Date: Tue Mar 7 01:58:39 2017 >>> New Revision: 314819 >>> URL: https://svnweb.freebsd.org/changeset/base/314819 >>> >>> Log: >>> MFC r313438: >>> >>> Clean up trailing and leading whitespace for variables to make it >>> consistent with the rest of the file and style.Makefile(9) a bit >>> more >>> >>> Modified: >>> stable/11/lib/libutil/Makefile >>> Directory Properties: >>> stable/11/ (props changed) >>> >>> Modified: stable/11/lib/libutil/Makefile >>> ============================================================================== >>> --- stable/11/lib/libutil/Makefile Tue Mar 7 01:52:56 2017 >>> (r314818) >>> +++ stable/11/lib/libutil/Makefile Tue Mar 7 01:58:39 2017 >>> (r314819) >>> @@ -35,7 +35,7 @@ MAN+= expand_number.3 flopen.3 fparseln. >>> property.3 pty.3 quotafile.3 realhostname.3 realhostname_sa.3 \ >>> _secure_path.3 trimdomain.3 uucplock.3 pw_util.3 >>> MAN+= login.conf.5 >>> -MLINKS+= kld.3 kld_isloaded.3 kld.3 kld_load.3 >>> +MLINKS+=kld.3 kld_isloaded.3 kld.3 kld_load.3 >>> MLINKS+=login_auth.3 auth_cat.3 login_auth.3 auth_checknologin.3 >>> MLINKS+=login_cap.3 login_close.3 login_cap.3 login_getcapbool.3 \ >> >> Thats actually counter style.Makefile(9), Normally you have a tab here, >> or a space should the variable name extend beyond column 9. >> >>> login_cap.3 login_getcaplist.3 login_cap.3 login_getcapnum.3 \ >>> @@ -57,9 +57,9 @@ MLINKS+=pidfile.3 pidfile_close.3 \ >>> pidfile.3 pidfile_open.3 \ >>> pidfile.3 pidfile_remove.3 \ >>> pidfile.3 pidfile_write.3 >>> -MLINKS+= property.3 property_find.3 property.3 properties_free.3 >>> -MLINKS+= property.3 properties_read.3 >>> -MLINKS+= pty.3 forkpty.3 pty.3 openpty.3 >>> +MLINKS+=property.3 property_find.3 property.3 properties_free.3 >>> +MLINKS+=property.3 properties_read.3 >>> +MLINKS+=pty.3 forkpty.3 pty.3 openpty.3 >> >> Ditto. > > Yeah, I tried to leave things alone (except is surrounding areas for the > following change), but I’ll go and hack away at the Makefile some more. > Thanks,
Actually, on second thought, I’m not going to modify the Makefile to just introduce gratuitous whitespace. If I need to touch this again, I’ll do it, but it doesn’t make sense churning over this Makefile like that (it’s a mishmash of different “styles”). Thanks, -Ngie
signature.asc
Description: Message signed with OpenPGP using GPGMail
