In message <201702040553.v145r1wb002...@repo.freebsd.org>, Warner Losh
writes:
> Author: imp
> Date: Sat Feb 4 05:53:00 2017
> New Revision: 313191
> URL: https://svnweb.freebsd.org/changeset/base/313191
>
> Log:
> Implement 5 wdc-specific nvme control options for their HGST drives:
> wdc cap-diag Capture diagnostic data from drive
> wdc drive-log Capture drive history data from drive
> wdc get-crash-dump Retrieve firmware crash dump from drive
>
> Added:
> head/sbin/nvmecontrol/wdc.c (contents, props changed)
> Modified:
> head/sbin/nvmecontrol/Makefile
> head/sbin/nvmecontrol/nvmecontrol.8
> head/sbin/nvmecontrol/nvmecontrol.c
> head/sbin/nvmecontrol/nvmecontrol.h
[...]
> + while (len > 0) {
> + resid = len > NVME_MAX_XFER_SIZE ? NVME_MAX_XFER_SIZE : len;
> + wdc_get_data(fd, opcode, resid, offset, cmd, buf, resid);
> + if (write(fd2, buf, resid) != resid)
Hi Warner,
I'm seeing the following on i386.
opt/src/svn-current/sbin/nvmecontrol/wdc.c:156:30: error: comparison of
integers of different signs: 'ssize_t' (aka 'int') and 'uint32_t' (aka
'unsigned int') [-Werror,-Wsign-compare]
if (write(fd2, buf, resid) != resid)
~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~
1 error generated.
amd64 builds okay.
> + err(1, "write");
> + offset += resid;
> + len -= resid;
> + }
> + free(buf);
> + close(fd2);
[...]
--
Cheers,
Cy Schubert <cy.schub...@cschubert.com>
FreeBSD UNIX: <c...@freebsd.org> Web: http://www.FreeBSD.org
The need of the many outweighs the greed of the few.
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
