> On Jan 19, 2017, at 23:27, Xin Li <delp...@delphij.net> wrote: > > > > On 1/19/17 23:13, Ngie Cooper (yaneurabeya) wrote: >> >>> On Jan 19, 2017, at 22:45, Xin LI <delp...@freebsd.org> wrote: >>> >>> Author: delphij >>> Date: Fri Jan 20 06:45:06 2017 >>> New Revision: 312519 >>> URL: https://svnweb.freebsd.org/changeset/base/312519 >>> >>> Log: >>> Revert r312404 as we need to do an exp-run and fix existing ports that >>> rely on the previous behavior. >>> >>> Requested by: antonie (portmgr) >> >> I added 2 testcases to help check for this behavior later in r312521. >> All that needs to be done is remove this line: >> https://svnweb.freebsd.org/base/head/usr.bin/sed/tests/sed2_test.sh?view=markup&pathrev=312521#l50 >> . > > Hmm to be honest I believe the old behavior is wrong and the intent is > to reinstate the revision after we have fixed the ports.
I agree — once the revision is fixed and committed, it will verify that
sed again fails.
If that’s not correct per the designed fix, we can modify the testcase
further.
Thanks :),
-Ngie
signature.asc
Description: Message signed with OpenPGP using GPGMail
