On Wed, Nov 23, 2016 at 11:06:53AM -0800, Bryan Drewery wrote:
> On 11/15/2016 1:37 AM, Konstantin Belousov wrote:
> > Author: kib
> > Date: Tue Nov 15 09:37:35 2016
> > New Revision: 308687
> > URL: https://svnweb.freebsd.org/changeset/base/308687
> >
> > Log:
> > Update hint to utilize user variable.
> >
> > Sponsored by: The FreeBSD Foundation
> > MFC after: 1 week
> >
> > Modified:
> > head/libexec/rtld-elf/Makefile
> >
> > Modified: head/libexec/rtld-elf/Makefile
> > ==============================================================================
> > --- head/libexec/rtld-elf/Makefile Tue Nov 15 09:20:28 2016
> > (r308686)
> > +++ head/libexec/rtld-elf/Makefile Tue Nov 15 09:37:35 2016
> > (r308687)
> > @@ -2,7 +2,7 @@
> >
> > # Use the following command to build local debug version of dynamic
> > # linker:
> > -# make DEBUG_FLAGS=-g DEBUG=-DDEBUG MK_TESTS=no all
> > +# make DEBUG_FLAGS=-g DEBUG=-DDEBUG WITHOUT_TESTS=yes all
>
> What prompted this change? Passing MK_TESTS=no should work fine.
I thought that the intent was to expose WITH_/WITHOUT_ knobs to users,
and keep MK_ to internal build machinery. This most likely come from
reading commit logs which I cannot dig now.
For start, only WITH_/WITHOUT_ are documented in src.conf. Second, the
very beginning of src.opts.mk says
# Users define WITH_FOO and WITHOUT_FOO on the command line or in /etc/src.conf
# and /etc/make.conf files. These translate in the build system to
MK_FOO={yes,no}
# with sensible (usually) defaults.
Then it adds
# Define MK_* variables (which are either "yes" or "no") for users
# to set via WITH_*/WITHOUT_* in /etc/src.conf and override in the
# make(1) environment.
IMO it is relatively easy to make the same conclusion as I did, from the
text above.
>
> >
> > .include <src.opts.mk>
> > PACKAGE= clibs
> >
>
>
> --
> Regards,
> Bryan Drewery
>
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
