Assuming we'd like to enable building with both compilers for now, isn't it better to use a form both accept?
Best, Conrad On Sun, Sep 4, 2016 at 12:31 PM, Dimitry Andric <d...@freebsd.org> wrote: > On 04 Sep 2016, at 20:57, Conrad Meyer <c...@freebsd.org> wrote: >> >> On Sun, Sep 4, 2016 at 10:55 AM, Dimitry Andric <d...@freebsd.org> wrote: >>> Author: dim >>> Date: Sun Sep 4 17:55:22 2016 >>> New Revision: 305392 >>> URL: https://svnweb.freebsd.org/changeset/base/305392 >>> >>> Log: >>> For kernel builds, instead of suppressing certain clang warnings, make >>> them non-fatal, so there is some incentive to fix them eventually. >>> >>> Modified: >>> head/sys/conf/kern.mk >>> >>> Modified: head/sys/conf/kern.mk >>> ============================================================================== >>> --- head/sys/conf/kern.mk Sun Sep 4 17:50:23 2016 (r305391) >>> +++ head/sys/conf/kern.mk Sun Sep 4 17:55:22 2016 (r305392) >>> @@ -17,13 +17,13 @@ CWARNFLAGS?= -Wall -Wredundant-decls -Wn >>> # kernel where fixing them is more trouble than it is worth, or where there >>> is >>> # a false positive. >>> .if ${COMPILER_TYPE} == "clang" >>> -NO_WCONSTANT_CONVERSION= -Wno-constant-conversion >>> -NO_WSHIFT_COUNT_NEGATIVE= -Wno-shift-count-negative >>> -NO_WSHIFT_COUNT_OVERFLOW= -Wno-shift-count-overflow >>> -NO_WSELF_ASSIGN= -Wno-self-assign >>> -NO_WUNNEEDED_INTERNAL_DECL= -Wno-unneeded-internal-declaration >>> +NO_WCONSTANT_CONVERSION= -Wno-error-constant-conversion >>> +NO_WSHIFT_COUNT_NEGATIVE= -Wno-error-shift-count-negative >>> +NO_WSHIFT_COUNT_OVERFLOW= -Wno-error-shift-count-overflow >>> +NO_WSELF_ASSIGN= -Wno-error-self-assign >>> +NO_WUNNEEDED_INTERNAL_DECL= -Wno-error-unneeded-internal-declaration >>> NO_WSOMETIMES_UNINITIALIZED= -Wno-error-sometimes-uninitialized >>> -NO_WCAST_QUAL= -Wno-cast-qual >>> +NO_WCAST_QUAL= -Wno-error-cast-qual >> >> I like goal of the change. Shouldn't these be -Wno-error=cast-qual, >> etc., though? > > That's how gcc spells them. Clang accepts both forms, there is no > functional difference. > > -Dimitry > _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
