My sincere apologies for missing this the first N times I reviewed it,
but both variables in functions should be declared local. Attached is
a suggested patch.


Doug

-- 

    This .signature sanitized for your protection

Index: static_arp
===================================================================
--- static_arp  (revision 196550)
+++ static_arp  (working copy)
@@ -41,10 +41,11 @@
 
 static_arp_start()
 {
+       local e arp_args
+
        if [ -n "${static_arp_pairs}" ]; then
                echo -n 'Binding static ARP pair(s):'
                for e in ${static_arp_pairs}; do
-                       local arp_args
                        echo -n " ${e}"
                        eval arp_args=\$static_arp_${e}
                        arp -S ${arp_args} >/dev/null 2>&1
@@ -55,10 +56,11 @@
 
 static_arp_stop()
 {
+       local e arp_args
+
        if [ -n "${static_arp_pairs}" ]; then
                echo -n 'Unbinding static ARP pair(s):'
                for e in ${static_arp_pairs}; do
-                       local arp_args
                        echo -n " ${e}"
                        eval arp_args=\$static_arp_${e}
                        arp -d ${arp_args%%[    ]*} > /dev/null 2>&1
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to