On Tue, Aug 18, 2009 at 08:06:17PM +0200, Attilio Rao wrote: > 2009/8/18 Sam Leffler <s...@errno.com>: > > Pawel Jakub Dawidek wrote: > >> > >> Author: pjd > >> Date: Tue Aug 18 13:55:48 2009 > >> New Revision: 196358 > >> URL: http://svn.freebsd.org/changeset/base/196358 > >> > >> Log: > >> Remove unused taskqueue_find() function. > >> Reviewed by: dfr > >> Approved by: re (kib) > > > > I don't understand why this should be removed (let alone during a code > > freeze). I can think of several uses for this function including a ddb cmd > > that takes a taskq name and dumps it's contents. The overhead of > > maintaining the global list appears minimal. > > FWIW, I agree with Sam.
The only use I could think of was exactly what Sam suggested - a DDB command and that was the only possible use I found. I decided to propose removal of this KPI, because nobody decided to use it for more than 9 years now and this is a good thing to remove unused code, no? I won't fight for keeping it removed, really. If after 9 years someone will find it useful I'm all for bringing it back. -- Pawel Jakub Dawidek http://www.wheel.pl p...@freebsd.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am!
pgppvhImL2KXU.pgp
Description: PGP signature
