Author: kib
Date: Thu Jun 16 12:01:11 2016
New Revision: 301960
URL: https://svnweb.freebsd.org/changeset/base/301960

Log:
  Remove XXX comments from kern_thread.c.  In one case, there is no
  reason for it in modern times.  In the other case, expand the comment
  stating instead of doubting.
  
  Reviewed by:  jhb
  Sponsored by: The FreeBSD Foundation
  MFC after:    1 week
  Approved by:  re (hrs)
  X-Differential revision:      https://reviews.freebsd.org/D6731

Modified:
  head/sys/kern/kern_thread.c

Modified: head/sys/kern/kern_thread.c
==============================================================================
--- head/sys/kern/kern_thread.c Thu Jun 16 11:58:46 2016        (r301959)
+++ head/sys/kern/kern_thread.c Thu Jun 16 12:01:11 2016        (r301960)
@@ -480,7 +480,7 @@ thread_exit(void)
         * architecture specific resources that
         * would not be on a new untouched process.
         */
-       cpu_thread_exit(td);    /* XXXSMP */
+       cpu_thread_exit(td);
 
        /*
         * The last thread is left attached to the process
@@ -907,8 +907,8 @@ thread_suspend_check(int return_instead)
                        /*
                         * The only suspension in action is a
                         * single-threading. Single threader need not stop.
-                        * XXX Should be safe to access unlocked
-                        * as it can only be set to be true by us.
+                        * It is safe to access p->p_singlethread unlocked
+                        * because it can only be set to our address by us.
                         */
                        if (p->p_singlethread == td)
                                return (0);     /* Exempt from stopping. */
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to