-----Original Message----- From: Jason Harmening <jason.harmen...@gmail.com> Date: 2016-05-19, Thursday at 21:05 To: Ravi Pokala <rpok...@mac.com>, "Jason A. Harmening" <j...@freebsd.org>, <src-committ...@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-h...@freebsd.org> Subject: Re: svn commit: r300258 - head/sys/dev/iicbus
>On 05/19/16 20:50, Ravi Pokala wrote: >> -----Original Message----- >> From: <owner-src-committ...@freebsd.org> on behalf of "Jason A. Harmening" >> <j...@freebsd.org> >> Date: 2016-05-19, Thursday at 20:03 >> To: <src-committ...@freebsd.org>, <svn-src-all@freebsd.org>, >> <svn-src-h...@freebsd.org> >> Subject: svn commit: r300258 - head/sys/dev/iicbus >> >> Hi Jason, >> >> If I’m reading that right, it’s not preventing any allocations, but it is >> preventing a leak. Is that correct? >> >> Thanks, >> >> Ravi (rpokala@) > >Hi Ravi, > >There shouldn't be a leak in here, but checking the result prevents >falling through the rest of the function, including the unnecessary >malloc of usrbufs right after this. How did I miss that earlier? Time for new glasses! :-P >It also makes the error handling clearer. Yeah. >Thanks, >Jason Thank *you*, Ravi (rpokala@) _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
