A shorter timeout dramatically cuts the length of time that the queue has to be frozen for error recovery. This allows one, in theory, to recover the system more quickly after a drive goes off into the weeds.
Warner > On Apr 15, 2016, at 9:23 AM, Ronald Klop <ronald-li...@klop.ws> wrote: > > Hello, > > Out of curiosity, what are these big problems? Broken device or other things > (timeouts/triggers/full queues) going on in the kernel? > > Regards, > Ronald. > > > On Fri, 15 Apr 2016 00:13:46 +0200, Warner Losh <i...@freebsd.org> wrote: > >> Author: imp >> Date: Thu Apr 14 22:13:46 2016 >> New Revision: 298011 >> URL: https://svnweb.freebsd.org/changeset/base/298011 >> erLog: >> Add a comment about why the timeout for flush was lowered to 5s. >> >> Modified: >> head/sys/cam/ata/ata_da.c >> >> Modified: head/sys/cam/ata/ata_da.c >> ============================================================================== >> --- head/sys/cam/ata/ata_da.c Thu Apr 14 22:13:44 2016 >> (r298010) >> +++ head/sys/cam/ata/ata_da.c Thu Apr 14 22:13:46 2016 >> (r298011) >> @@ -912,6 +912,11 @@ adadump(void *arg, void *virtual, vm_off >> if (softc->flags & ADA_FLAG_CAN_FLUSHCACHE) { >> xpt_setup_ccb(&ccb.ccb_h, periph->path, CAM_PRIORITY_NORMAL); >> + /* >> + * Tell the drive to flush its intenral cache. if we >> + * can't flush in 5s we have big problems. No need to >> + * wait the default 60s to detect problems. >> + */ >> ccb.ccb_h.ccb_state = ADA_CCB_DUMP; >> cam_fill_ataio(&ccb.ataio, >> 0, >> _______________________________________________ >> svn-src-all@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/svn-src-all >> To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
signature.asc
Description: Message signed with OpenPGP using GPGMail
