On Wed, Oct 21, 2015 at 08:42:02AM -0700, Bryan Drewery wrote: B> >>> Log: B> >>> Start process of moving the LinuxKPI into the default kernel build by B> >>> creating an empty directory tree. B> >>> B> >>> Sponsored by: Mellanox Technologies B> >>> B> >>> Added: B> >>> head/sys/compat/linuxkpi/ B> >>> head/sys/compat/linuxkpi/common/ B> >>> head/sys/compat/linuxkpi/common/include/ B> >>> head/sys/compat/linuxkpi/common/include/asm/ B> >>> head/sys/compat/linuxkpi/common/include/linux/ B> >>> head/sys/compat/linuxkpi/common/src/ B> >>> B> >> B> >> This makes me think a branch should be used instead. B> >> B> > B> > Most of what will be done is "svn mv" out of "sys/ofed" and changing B> > some include paths in sys/modules and sys/conf . Can you explain why you B> > think a branch is required ? B> B> Because you're splitting commits up that should otherwise not be split B> up. There's no reason to commit empty directories before a 'svn mv' into B> them.
+1 Any commit to head should be an atomic change that does something useful: fixes smth, adds something useful, or removes something obsoleted. You can either bring in the linuxkpi to head in a single commit, or, if you prefer to do a serie of commits, where intermediate state is rather meaningless, then you should do this serie in a separate branch, and then produce patch from the branch and commit it to head. There is no need to revert r289700. This is just a note for future. -- Totus tuus, Glebius. _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
