On Wed, Aug 05, 2015 at 08:04:55PM -0700, K. Macy wrote: > On Wed, Aug 5, 2015 at 7:22 PM, Glen Barber <g...@freebsd.org> wrote: > > On Thu, Aug 06, 2015 at 04:17:23AM +0200, Pawel Jakub Dawidek wrote: > >> On Mon, Aug 03, 2015 at 04:20:04PM +0300, Andriy Gapon wrote: > >> > On 30/07/2015 10:24, K. Macy wrote: > >> > > Just FYI this change introduces a deadlock with with the > >> > > spa_namespace_lock. Mount will be holding this lock while trying to > >> > > acquire the spa_namespace_lock. zfskern on the other hand holds the > >> > > spa_namespace_lock when calling zfs_freebsd_access which in turn > >> > > tries to acquire the teardown lock. > >> > > >> > I missed the fact that zpool.cache file is being written with > >> > spa_namespace_lock > >> > held. > >> > I'll try to either resolve the problem in the next day or I will revert > >> > the change. > >> > >> FYI, I'm hitting this deadlock on my laptop. Reverting the change fixes > >> the problem. > >> > > > > Since it is now 3 days after "I'll try to either resolve the problem in > > the next day or I will revert the change", my view is that this needs to > > be reverted now, if it hasn't been done already. > > > His proposed solution looks fine to me. Why don't we commit that? >
I must have missed the solution - was it part of this thread? If a solution exists, then yes, that should be the fix instead. Glen
pgpAuJ4Spik9v.pgp
Description: PGP signature
