Andrew Thompson wrote:
Author: thompsa
Date: Fri Feb 27 21:14:29 2009
New Revision: 189123
URL: http://svn.freebsd.org/changeset/base/189123

Log:
  Partial sync to //depot/projects/usb
- Reissue the ctrl request on failure
  - Ensure Tx and ctrl requests are not interleaved
  - Add promisc callbacks
Obtained from: Hans Petter Selasky

+static void
+rum_update_mcast(struct ifnet *ifp)
+{
+       /* not supported */
+}

This and similar additions for the other drivers are wrong. They don't implement the functionality which means multicast filtering will be silently broken. Drivers should only fill-in the callback if they do the work. If someone were to fix IFF_ALLMULTI support then net80211 could just fall back on it when drivers don't have or implement proper mcast filtering.

A cursory scan shows some odd changes in places like vap_delete but don't have time to look closely. It appears the commit msg does not reflect the changes.

   Sam

_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to