On Wed, Jan 28, 2009 at 12:18 PM, Andrew Thompson <thom...@freebsd.org> wrote: > On Wed, Jan 28, 2009 at 08:06:02PM +0000, Maksim Yevmenkin wrote: >> Author: emax >> Date: Wed Jan 28 20:06:02 2009 >> New Revision: 187866 >> URL: http://svn.freebsd.org/changeset/base/187866 >> >> Log: >> Update ubtbcmfw2 (aka usb2_bluetooth_fw) driver >> >> Reviewed by: HPS >> >> enum { >> - UBTBCMFW_BULK_DT_WR, >> - UBTBCMFW_BULK_DT_RD, >> - UBTBCMFW_BULK_CS_WR, >> - UBTBCMFW_BULK_CS_RD, >> - UBTBCMFW_N_TRANSFER = 4, >> + UBTBCMFW_BULK_DT_WR = 0, >> + UBTBCMFW_INTR_DT_RD, >> + UBTBCMFW_N_TRANSFER, >> }; > > I found it more useful the other way around which showed the number of > transfers at a glance of UBTBCMFW_N_TRANSFER. (I realise you removed one)
two actually. all transfer stalls are now handled internally (as per HPSs suggestion). in any case, it seemed like a good idea to do it this way because those values used as indexes to an array. just wanted to make sure that all transfers are in their right places :) dont really have a particularly strong opinion on this though :) and its only 2 values we are talking about here :) thanks, max _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
