Bjoern A. Zeeb schrieb:
On Mon, 5 Jan 2009, Christoph Mallon wrote:
Bjoern A. Zeeb schrieb:
I have broken it out from a larger patch; the C99 initializer is here:
http://people.freebsd.org/~bz/20090105-02-c99-initializers.diff

I case someone can give it a quick glance I'll commit them.

+    .pr_flags    = PR_ATOMIC|PR_ADDR,

style(9) wants spaces around binary operators.

I am not sure it does.

"Unary operators do not require spaces, binary operators do."
I guess only "usual" binary operators are meant here and it does not include ",", "[]" or "->".

In case it does I am not going to break
consistency with all other 65 places that don't do for pr_flags;

You have a point there. Maybe these should be fixed all at once.

but it seems I should change the <tab>=<space> to <space>=<tab>.

<tab> /after/ =? This sounds wrong to me.
(In general I think using <tab> for alignment is a bad idea and it should only be used for indentation)
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "[email protected]"

Reply via email to