Maxim Konovalov wrote:
Author: mav
Date: Tue Nov 18 15:48:23 2008
New Revision: 185053
URL: http://svn.freebsd.org/changeset/base/185053

Log:
  Restore original frequency on exit.

  PR:           bin/113813

[ patch skipped ]

Not sure this is a correct aproach.  What happen if admin
changed (rose or lowered) the debug.cpufreq.lowest after he
run powerd?  So imho at exit we need to take an account a
current value of debug.cpufreq.lowest.

Then powerd may not restore original frequency. IMHO it is a bad idea to modify anything frequency related while powerd is running as it reads frequency set only once and them mostly writes.

Every tool should have it's own task. powerd has no idea about debug.cpufreq.lowest, especially because of "debug.". It is kernel internal business, how to generate set of frequencies. If we need specify lowest frequency for adaptive mode, I would teach powerd to do it, not the kernel.

--
Alexander Motin
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"

Reply via email to