Hi Fabien et all,

please see the following obvious patch for downloading redirected
files. Without it, I cannot download more star files (and basically
anything redirected), and stellarium (builded with debug) crashed on

Q_ASSERT(starCatalogDownloadReply->bytesAvailable()==0);

as obviously that was tested before redirection tests.

Can anybody implement the patch? Or should I create branch and propose
merge?

Petr
http://rts2.org (I have RTS2 client running, will clean it up and merge
later)
=== modified file 'src/gui/ConfigurationDialog.cpp'
--- src/gui/ConfigurationDialog.cpp	2015-10-24 10:57:16 +0000
+++ src/gui/ConfigurationDialog.cpp	2015-11-23 00:01:48 +0000
@@ -1131,6 +1131,8 @@
 	progressBar->setValue(0);
 	progressBar->setRange(0, nextStarCatalogToDownload.value("sizeMb").toDouble()*1024);
 	progressBar->setFormat(QString("%1: %p%").arg(nextStarCatalogToDownload.value("id").toString()));
+
+	qDebug() << "Downloading file" << nextStarCatalogToDownload.value("url").toString();
 }
 
 void ConfigurationDialog::downloadError(QNetworkReply::NetworkError)
@@ -1165,8 +1167,6 @@
 		return;
 	}
 
-	Q_ASSERT(starCatalogDownloadReply->bytesAvailable()==0);
-
 	const QVariant& redirect = starCatalogDownloadReply->attribute(QNetworkRequest::RedirectionTargetAttribute);
 	if (!redirect.isNull())
 	{
@@ -1184,6 +1184,8 @@
 		return;
 	}
 
+	Q_ASSERT(starCatalogDownloadReply->bytesAvailable()==0);
+
 	isDownloadingStarCatalog = false;
 	currentDownloadFile->close();
 	currentDownloadFile->deleteLater();

------------------------------------------------------------------------------
Go from Idea to Many App Stores Faster with Intel(R) XDK
Give your users amazing mobile app experiences with Intel(R) XDK.
Use one codebase in this all-in-one HTML5 development environment.
Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140
_______________________________________________
Stellarium-pubdevel mailing list
Stellarium-pubdevel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel

Reply via email to