On So, 12.10.2014, 13:42, Alexander Wolf wrote: > Howdy all! > > A few days ago people began say about troubles with downloading of extra > star catalogs (e.g. https://bugs.launchpad.net/stellarium/+bug/1379241 and > https://sourceforge.net/p/stellarium/discussion/278769/thread/c37d96bc/). > > I'm was spend around one day for investigate source of the issue (include > talk on the #sourceforge IRC channel and request to technical support on > SF.net). > > Results? Yeah, I have results: Stellarium can't recognize status of > redirect and put redirect answer from server within file! WTF??? Code for > support of downloading extra catalogs is messy and difficult for support > :-/ Plus all plugins and some other parts of Stellarium has a separate > implementation of network sessions for download the stuff. > > Maybe we should implement StelNetwork class with code for working with > network sessions for all Stellarium (include correct parse redirects and > network errors) and use this code for all network sessions? > > Any comments? > > P.S. Broken extra catalogs is release blocked bug at now. >
Sounds bad! Fabien required me to use the centralized App's NetworkAccessManager when I did the IP location lookup. I had seen many other classes using their own, so was not aware of issues having my own at first. What's certainly required is more robust handling of the answers. But servers outside stellarium.org (comet/asteroid/satellite element lookup, ...) may give very diverse answers, not sure if a centralized handler can catch all cases. A short check and in case of unexpected answer graceful exit of function (with error panel or at least log entry "network connection failed, unexpected answer: %1" etc) and non-change of catalog files should be reasonably simple to add. Further handling like re-request, redirection etc. may be worth considering, but I never went deep enough into the messy details here. G. ------------------------------------------------------------------------------ Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://p.sf.net/sfu/Zoho _______________________________________________ Stellarium-pubdevel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel
