On Tue, Feb 14, 2012 at 12:55 AM, Matthew Gates <[email protected]> wrote: > Hi, > > Just saw a commit from treaves about the safe mode being "moved to the > windows #define, where it is used". What happened with safe mode. I > had noticed that a release or two after it was originally implemented, > it has effectively been disabled. Was that deliberate or a mistake? > > Also, I don't think it should be platform specific. IIRC, safe mode > should disable shaders where possible and choose the less > problem-causing paint engine backend... I am aware of graphics card > problems which may be helped by these precautions on both windows and > linux (don't know about the mac world), so the safe mode should > function on at least windows and linux too, not just windows. > > Can someone bring me up to speed on what has happened / the status of safe > mode?
TR's commit was a misunderstanding - he thought that the if/else set only the safeMode variable, which was used only in the Windows #ifdef below. He hadn't noticed the line that sets the paint engine. He fixed it after I pointed it out to him: http://bazaar.launchpad.net/~stellarium/stellarium/trunk/revision/5172 At the moment, setting safe mode in the whole application is done through the "onetime_safe_mode" dynamic property of Stellarium's QApp object. Search the code for that string to see the other instances. I don't remember who did it, it's possible that at the time I wasn't following Stellarium. You can use Bazaar's "annotate" feature to find out, if it's really important. Bogdan ------------------------------------------------------------------------------ Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d _______________________________________________ Stellarium-pubdevel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel
