I implemented 1 & 3. Alex, I don't want to commit the change unless you're happy with it, so I'm attaching a patch file.
M On 12 February 2012 20:36, Matthew Gates <matthew...@gmail.com> wrote: > Alex, > > I had some more thoughts about the pulsars plugin after you did the merge. > > 1. [very quick] It might be good to add something to the plugin > description which appears on the plugins tab of the config dialog... > I think it would be helpful to have a note (perhaps in a second > paragraph) to say that pulsar objects can be found by searching for > "PSR ...". > > 2. It might be a nice idea to have a toolbar button / keyboard command > to toggle the display of pulsars (although the lack of clutter in the > toolbar is also nice... > > 3. I mentioned this in the IRC the other day, but I think it's world > re-stating. I would like for the identifier in the catalog.json file > to include the "PSR J" prefix, rather than have the plugin > automatically prepend this to whatever is in the catalog.json file. I > feel this makes things clearer for people who want to understand the > plugin. This would require a few small changes: > > a) remove the code which adds the "PSR J" prefix > b) change the catalog.json file generation perl script to add the > prefix (since it is not in the source data) > c) generate and copy the new catalog.json file from the util to the > resources directory. > > I'm happy to do this unless you object to the proposal. > > > M
pulsars_20120212_1.patch.bz2
Description: BZip2 compressed data
------------------------------------------------------------------------------ Try before you buy = See our experts in action! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-dev2
_______________________________________________ Stellarium-pubdevel mailing list Stellarium-pubdevel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel
