On Tue, Nov 27, 2012 at 02:08:43PM -0800, Stephen Hemminger wrote: > On Tue, 27 Nov 2012 21:46:41 +0100 > Peter Huewe <[email protected]> wrote: > > > From: stephen hemminger <[email protected]> > > > > Use be32_to_cpu instead of htonl to keep sparse happy. > > > > Signed-off-by: Stephen Hemminger <[email protected]> > > Signed-off-by: David S. Miller <[email protected]> > > > > Sparse warning was probably: > > net/ipv4/ip_vti.c:387:28: sparse: cast from restricted __be32 > > net/ipv4/ip_vti.c:454:36: sparse: cast from restricted __be32 > > Reported-by: Fengguang Wu <[email protected]> > > > > Cc: <[email protected]> # 3.6.x b0558ef24 > > Cc: <[email protected]> # 3.6.x > > Upstream-ID: 8437e7610c2d3e06f87f71fb82e10ed4b291812a > > Stable-Trees: 3.6 > > Signed-off-by: Peter Huewe <[email protected]> > > I don't see the point of putting this in stable since it does not > fix an actual bug, only eliminates warning with a tool. It fails > on the criteria: > > - It must fix a real bug that bothers people (not a, "This could be a > problem..." type thing).
I agree, sparse warnings are NOT something to backport to stable kernels, it's just not worth it. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
