[email protected] wrote: > commit d387b427c973974dd619a33549c070ac5d0e089f upstream. > > The new 84xx stopped flying below the radars. > > Signed-off-by: Francois Romieu <[email protected]> > Cc: Hayes Wang <[email protected]> > Reviewed-by: Jonathan Nieder <[email protected]>
I only reviewed patch #7 (a while ago, with help from François). Let's see. With this patch, the driver starts writing the wake-on-lan setting to the 6th least significant bit of the Config2 register. Based on the commit message, it is especially relevant for the 84xx. Searching the web for 84xx, the RTL8402 and RTL8411 show up, newish devices that function as both a NIC and a card reader. Example: https://bugs.launchpad.net/bugs/971876 This patch does not just affect the RTL8402 and RTL8411, though. All RTL8168c, RTL8168cp, RTL8168d, ..., RTL8168f cards are affected as well. I think before v3.1-rc1~316^2~132^2~5 ("r8169: modify the flow of the hw reset") WOL was supposed to work on at least some cards. Which cards are broken without this fix? Is the fix sufficient on 3.0.y to make them work? It seems plausible that the patch is good but I am too ignorant to give a Reviewed-by for it. Thanks, Jonathan -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
