Subject: [PATCH 2.6.32 01/12] TTY: drop driver reference in tty_open fail path

From: Jiri Slaby <[email-masked]>
Date: Wed, 12 Oct 2011 11:32:42 +0200

commit c290f8358acaeffd8e0c551ddcc24d1206143376 upstream.

When tty_driver_lookup_tty fails in tty_open, we forget to drop a
reference to the tty driver. This was added by commit 4a2b5fddd5 (Move
tty lookup/reopen to caller).

Fix that by adding tty_driver_kref_put to the fail path.

I will refactor the code later. This is for the ease of backporting to
stable.

Introduced-in: v2.6.28-rc2
Signed-off-by: Jiri Slaby <[email-masked]>
Cc: Alan Cox <[email-masked]>
Acked-by: Sukadev Bhattiprolu <[email-masked]>
Signed-off-by: Greg Kroah-Hartman <[email-masked]>
[bwh: Backported to 2.6.32: adjust filename]
Signed-off-by: Ben Hutchings <[email-masked]>
---
 drivers/char/tty_io.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c
index cbdd1698..6c71534 100644
--- a/drivers/char/tty_io.c
+++ b/drivers/char/tty_io.c
@@ -1779,6 +1779,7 @@ got_driver:
 
 		if (IS_ERR(tty)) {
 			mutex_unlock(&tty_mutex);
+			tty_driver_kref_put(driver);
 			return PTR_ERR(tty);
 		}
 	}