On A MIPS 32-cores machine a BUG_ON was triggered because some acesses to
mtd->usecount were done without taking mtd_table_mutex.
kernel: Call Trace:
kernel: [<ffffffff80401818>] __put_mtd_device+0x20/0x50
kernel: [<ffffffff804086f4>] blktrans_release+0x8c/0xd8
kernel: [<ffffffff802577e0>] __blkdev_put+0x1a8/0x200
kernel: [<ffffffff802579a4>] blkdev_close+0x1c/0x30
kernel: [<ffffffff8022006c>] __fput+0xac/0x250
kernel: [<ffffffff80171208>] task_work_run+0xd8/0x120
kernel: [<ffffffff8012c23c>] work_notifysig+0x10/0x18
kernel:
kernel:
Code: 2442ffff ac8202d8 000217fe <00020336> dc820128 10400003
00000000 0040f809 00000000
kernel: ---[ end trace 080fbb4579b47a73 ]---
Fixed by taking the mutex in blktrans_open and by using the protected
version of put_mtd_device in blktrans_release and del_mtd_blktrans_dev
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Giuseppe Cantavenera <[email protected]>
Acked-by: Alexander Sverdlin <[email protected]>
---
drivers/mtd/mtd_blkdevs.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
index 2b0c5287..3a9f138 100644
--- a/drivers/mtd/mtd_blkdevs.c
+++ b/drivers/mtd/mtd_blkdevs.c
@@ -213,7 +213,9 @@ static int blktrans_open(struct block_device *bdev, fmode_t
mode)
goto error_put;
}
+ mutex_lock(&mtd_table_mutex);
ret = __get_mtd_device(dev->mtd);
+ mutex_unlock(&mtd_table_mutex);
if (ret)
goto error_release;
dev->file_mode = mode;
@@ -253,7 +255,7 @@ static void blktrans_release(struct gendisk *disk, fmode_t
mode)
if (dev->mtd) {
if (dev->tr->release)
dev->tr->release(dev);
- __put_mtd_device(dev->mtd);
+ put_mtd_device(dev->mtd);
}
unlock:
mutex_unlock(&dev->lock);
@@ -484,7 +486,7 @@ int del_mtd_blktrans_dev(struct mtd_blktrans_dev *old)
if (old->open) {
if (old->tr->release)
old->tr->release(old);
- __put_mtd_device(old->mtd);
+ put_mtd_device(old->mtd);
}
old->mtd = NULL;
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
