Should we deprecate add_contact_alias()? Add a warning message. -ovidiu
On Tue, Oct 14, 2014 at 9:44 AM, Daniel-Constantin Mierla <mico...@gmail.com> wrote: > Hello, > > short update on this topic - the master and 4.2 branches include a patch > that should make presence work with set_contact_alias(). > > It would be safer to use set_contact_alias(), especially if you have UA that > checks R-URI for incoming requests. > > Cheers, > Daniel > > > On 13/10/14 04:42, Thanh Truong wrote: > > Hi All, > > I have added : fix_natted_contact() and it fix this issue. > > Thank all for help. > > > Thanks, > ThanhTruong. > > > On Fri, Oct 10, 2014 at 8:39 PM, Ovidiu Sas <o...@voipembedded.com> wrote: >> >> I would prefer to have add_contact_alias deprecated and then dropped (less >> confusing this way). >> >> -ovidiu >> >> On Fri, Oct 10, 2014 at 9:31 AM, Daniel-Constantin Mierla >> <mico...@gmail.com> wrote: >>> >>> >>> On 10/10/14 14:54, Ovidiu Sas wrote: >>> >>> I don't think this is documented anywhere and it's challenging for >>> someone not familiar with kamailio to deal with it. >>> Maybe we should open a bug report to make presence *_contact_alias >>> friendly. >>> >>> add_contact_alias() is not going to be (very easy) friendly, by the way >>> was coded -- probably targeting only the requests that are proxied. >>> >>> It was the reason I added set_contact_alias() for fixing that, but I was >>> not sure how it will cope over all at the end. So the first follow up fix >>> was done inside dialog module (because I could test it at that moment), I >>> will push it now directly in tm to catch the other modules sending requests >>> within dialog. >>> >>> Eventually add_contact_alias() will be removed or 'aliased' to >>> set_contact_alias(). >>> >>> Daniel >>> >>> >>> -ovidiu >>> >>> On Fri, Oct 10, 2014 at 5:16 AM, Daniel-Constantin Mierla >>> <mico...@gmail.com> wrote: >>>> >>>> Hello, >>>> >>>> if the presence server is first hop after a nat router, then use >>>> fix_natted_contact() for SUBSCRIBE requests instead of >>>> add/set_contact_alias(). >>>> >>>> Cheers, >>>> Daniel >>>> >>>> On 05/10/14 06:52, Thanh Truong wrote: >>>> >>>> Hi all, >>>> >>>> I have install kamailio 4.2 latest version with presence module. >>>> >>>> But I cant get contact status and send message. >>>> >>>> [] >>>> >>>> I see that SUBSCRIBE message send to wrong ip, it is sent to local IP >>>> and my sip phone do not receive it. But i do not know how to fix it. >>>> >>>> please suggest to get it. >>>> >>>> >>>> -- >>>> Daniel-Constantin Mierla >>>> http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda >>>> >>>> >>>> _______________________________________________ >>>> SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list >>>> sr-users@lists.sip-router.org >>>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users >>>> >>> >>> >>> >>> -- >>> VoIP Embedded, Inc. >>> http://www.voipembedded.com >>> >>> >>> -- >>> Daniel-Constantin Mierla >>> http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda >> >> >> >> >> -- >> VoIP Embedded, Inc. >> http://www.voipembedded.com >> >> _______________________________________________ >> SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list >> sr-users@lists.sip-router.org >> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users >> > > > > _______________________________________________ > SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list > sr-users@lists.sip-router.org > http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users > > > -- > Daniel-Constantin Mierla > http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda > > > _______________________________________________ > SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list > sr-users@lists.sip-router.org > http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users > -- VoIP Embedded, Inc. http://www.voipembedded.com _______________________________________________ SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list sr-users@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
