Hello,
On 8/11/11 10:12 AM, Timo Reimann wrote:
Hey Graham,
On 10.08.2011 14:27, Graham Wooden wrote:
I would be interested in the 1.5 backported module. Is that available
for the masses?
I personally wouldn't mind publishing the backport code. One interesting
question, however, is in what form to do that. Several approaches come
to my mind:
- A separate branch with just the patch.
- A separate Kamailio 1.5 branch with the modified code.
- Distribution via the mailing list.
- Distribution in private.
Naturally, I'd favor something centralized to allow more people access
to the code.
@Daniel: What's your thought on this? Do you have a preferred way?
Maybe uploading it (a tarball if big or just the patch file) on the
tracker is another quite easy possibility. Either on the one from
sip-router.org, or, since it is 1.5, can be even on the sourceforge.net.
This will allow to upload new versions of the files if changes are
needed in the future. Then provide the link to the tracker item on the
mailing list.
I would prefer no commit on the mainstream SVN branches, so we do not
open past releases, that will create lot of confusion.
Cheers,
Daniel
Note, however, that the time frame we (as in my company) are going to
use, support, and maintain the 1.5 backport code is already now foreseeable.
Cheers,
--Timo
On 8/4/11 1:08 AM, "Timo Reimann"<timo.reim...@1und1.de> wrote:
Hi all,
as announced quite a while ago, I finally checked in code that
allows to
produce CDRs (Call Data Records) directly from SIP-Router and generate
logs accordingly.
The main code portion resides in modules_k/acc and provides a switch to
enable basic CDR generation including start time, end time, and
duration. Analogous to the existing logging approach, you may define an
extra parameter covering to-be-included dialog pseudo-variables that
must be assigned in the configuration script. The new code will take
care of transforming the basic and custom CDR fields into CDR logs at
the end of a dialog.
Speaking of dialogs: The implementation relies heavily on the dialog
module. It takes advantage of dialog variables introduces by Carsten
Bock and adds a few more features. Most notably, we had to change the
dialog callback signature to provide both request and response
messages.
Having only one of them proved to be insufficient in certain cases; for
instance, a locally generated 408 returned a FAKED_REPLY, thus
rendering
it impossible to access dialog variables through the PV framework.
Other
modules using dialog callbacks have been updated along the commit,
third-party modules outside the repository will need to do so too (and
think about whether using the request or response is the Right
Thing to do).
Due to the changes brought to the dialog module, I pushed the new acc
and dialog code into a separate branch called treimann/acc-cdr. Feel
free to give it a try by consulting the updated documentation and
suggesting (or, if it's good enough, implementing :) ) improvements. A
Kamailio 1.5 backport of the code has been in usage for quite some time
with us, so generally there shouldn't be any major logical flaws.
SIP-Router certainly needs more testing, however, so I'd be glad
for any
feedback. My plan is to merge the code into master branch prior to the
3.2 feature freeze, unless significant objections arise.
Finally, big-time credits go to my co-worker Sven Knoblich who is the
main contributor of the code. He's been working on this stuff for the
past few months and dreams in CDRs by now.
_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
--
Daniel-Constantin Mierla -- http://www.asipto.com
Kamailio Advanced Training, Oct 10-13, Berlin: http://asipto.com/u/kat
http://linkedin.com/in/miconda -- http://twitter.com/miconda
_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
