xkaraman left a comment (kamailio/kamailio#4492)
Hey @miconda,
Thanks for the review.
Got some question to clarify some things:
> KEMI function with the operator as parameter having same options like in the
> cfg variables
Is there somewhere documented what would these look like? The only docs i could
find is this
https://www.kamailio.org/wikidocs/cookbooks/6.0.x/pseudovariables/#shtcvhtableexp.
But this do not include any operation paramater. The operator is included in
the string given to search for like `shtcn(htable=>~~regexp`.
So maybe the new function just accept only pattern as parameter that already is
described here? with no mode or operator paramater at all?
I prefer the operator to be explicit to be honest just like you suggested but
it is not how cfg, pv variables are used. Correct me if i am wrong here.
> I think it would be better to have a single KEMI function
So no implementation for the specific operation at all? They are all using the
common function with selected operation as a convenience. I don't have a strong
preference here, if one can use the base for everything.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4492#issuecomment-3558933732
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4492/[email protected]>
_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the
sender!
