Module: kamailio Branch: master Commit: 8e54a975a7c06fb6e847dc623320d1227187301c URL: https://github.com/kamailio/kamailio/commit/8e54a975a7c06fb6e847dc623320d1227187301c
Author: Victor Seva <[email protected]> Committer: Victor Seva <[email protected]> Date: 2025-11-20T11:55:38+01:00 ims_registrar_scscf: fix update_contacts() after split return was 1 for success bug introduced at dc2df7865d76ae9767c43d45b5ea7a12354c6bae --- Modified: src/modules/ims_registrar_scscf/save.c --- Diff: https://github.com/kamailio/kamailio/commit/8e54a975a7c06fb6e847dc623320d1227187301c.diff Patch: https://github.com/kamailio/kamailio/commit/8e54a975a7c06fb6e847dc623320d1227187301c.patch --- diff --git a/src/modules/ims_registrar_scscf/save.c b/src/modules/ims_registrar_scscf/save.c index 11355cfd94e..c6eca2a9387 100644 --- a/src/modules/ims_registrar_scscf/save.c +++ b/src/modules/ims_registrar_scscf/save.c @@ -887,7 +887,7 @@ static int update_contacts_sar_registration(struct sip_msg *msg, udomain_t *_d, } ul.unlock_udomain(_d, public_identity); - return 0; + return 1; } static int update_contacts_sar_user_deregistration(struct sip_msg *msg, @@ -1098,7 +1098,7 @@ static int update_contacts_sar_user_deregistration(struct sip_msg *msg, shm_free(explicit_dereg_contact); } - return 0; + return ret; } static int update_contacts_sar_re_registration(struct sip_msg *msg, @@ -1236,7 +1236,7 @@ static int update_contacts_sar_re_registration(struct sip_msg *msg, } done: ul.unlock_udomain(_d, public_identity); - return 0; + return 1; } static int update_contacts_sar_unregistered_user(udomain_t *_d, @@ -1266,7 +1266,7 @@ static int update_contacts_sar_unregistered_user(udomain_t *_d, /* if we were successful up to this point, then we need to copy the contacts * from main impu record (asserted IMPU) into the register response */ - return 0; + return 1; } /** @@ -1291,7 +1291,7 @@ int update_contacts(struct sip_msg *msg, udomain_t *_d, str *public_identity, str *ecf1, str *ecf2, contact_for_header_t **contact_header) { int expires_hdr = -1; //by default registration doesn't expire - int ret = 1; + int ret = -1; if(msg) { //get the expires from the main body of the sip message (global) _______________________________________________ Kamailio - Development Mailing List -- [email protected] To unsubscribe send an email to [email protected] Important: keep the mailing list in the recipients, do not reply only to the sender!
