jchavanton left a comment (kamailio/kamailio#4358)

@furmur sorry I did not see that MR before.

I can see that your modification is aligned with the general formula of the 
EWMA, I am in favor of making the swap,  but we also need to update the 
documentation and the default value. 

We have the default value of .90 (900), that is use as the weight to the 
estimator (not the new sample).
`new-estimate = alpha * previous-estimate + (1-apha) * new sample`



```
3.28. ds_latency_estimator_alpha (int)

The value to be used to control the memory of the estimator EWMA "exponential 
weighted moving average" or "the speed at which the older samples are dampened" 
a good explanation can be found here : 
http://www.itl.nist.gov/div898/handbook/pmc/section3/pmc324.htm Because 
Kamailio doesn't support float parameter types, the value in the parameter is 
divided by 1000 and stored as float. For example, if you want to set the alpha 
to be 0.75, use value 750 here. 
```
Should become
```
3.28. ds_latency_estimator_alpha (int)

The parameter decides how important the current observation is in the 
calculation of the EWMA. The higher the value of alpha, the more closely the 
EWMA tracks the original time series.
Because Kamailio doesn't support float parameter types, the value in the 
parameter is divided by 1000 and stored as float. For example, if you want to 
set the alpha to be 0.25, use value 250 here. 
```

Default value should now be `0.10`






-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4358#issuecomment-3271202397
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/4358/c3271202...@github.com>
_______________________________________________
Kamailio - Development Mailing List -- sr-dev@lists.kamailio.org
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Important: keep the mailing list in the recipients, do not reply only to the 
sender!

Reply via email to